Skip to content

refactor: simplify overlay management in JS bridge code #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csouchet merged 1 commit into from
Sep 15, 2023
Merged

refactor: simplify overlay management in JS bridge code #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions inst/htmlwidgets/bpmnVisualizationR.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ HTMLWidgets.widget({
const overlayConfig = {...rest};

if(enableDefaultOverlayStyle && !(overlayConfig.style && overlayConfig.position)) {
const elementsByIds = bpmnVisualization.bpmnElementsRegistry.getElementsByIds(elementId);
if (elementsByIds.length) {
const isShape = elementsByIds[0].bpmnSemantic.isShape;
const elements = bpmnVisualization.bpmnElementsRegistry.getModelElementsByIds(elementId);
if (elements.length) {
const isShape = elements[0].isShape;
overlayConfig.style ??= buildDefaultOverlayStyle(isShape);
overlayConfig.position ??= buildDefaultOverlayPosition(isShape);
}
Expand All @@ -80,7 +80,7 @@ HTMLWidgets.widget({
},

// Make the bpmnVisualization object available as a property on the widget instance we're returning from factory().
// This is generally a good idea for extensibility--it helps users of this widget interact directly with bpmnVisualization, if needed.
// This is generally a good idea for extensibility: it helps users of this widget to interact directly with bpmnVisualization, if required.
s: bpmnVisualization
};
}
Expand Down