[INFRA] The release workflow fails to disable the branch protection rules

[tbouffard]

Seen while attempting to release version 0.2.2.
Workaround: follow the manual procedure

Workflow runs: https://github.com/process-analytics/bpmn-visualization-R/actions/runs/3533388259
3 attempts, all failed. The last one was run in debug mode, no additional information

Action configuration

Run benjefferies/branch-protection-bot@1.0.7
  with:
    access_token: ***
    enforce_admins: true
    branch: main
    retries: 5

Error stack

Getting branch protection settings for process-analytics/bpmn-visualization-R
Traceback (most recent call last):
  File "/bin/run.py", line 83, in <module>
    toggle_enforce_admin(p.parse_args())
  File "/bin/run.py", line 22, in toggle_enforce_admin
    protection = get_protection(access_token, branch_name, owner, repo_name)
  File "/bin/run.py", line 61, in get_protection
    protection = branch.protection()
  File "/pyroot/lib/python3.7/site-packages/github3/decorators.py", line 31, in auth_wrapper
    return func(self, *args, **kwargs)
  File "/pyroot/lib/python3.7/site-packages/github3/repos/branch.py", line 73, in protection
    json = self._json(resp, 200)
  File "/pyroot/lib/python3.7/site-packages/github3/models.py", line 157, in _json
    raise exceptions.error_for(response)
github3.exceptions.NotFoundError: 404 Not Found

[csouchet]

To test, I created a main branch on https://github.com/process-analytics/github-actions-playground, with a rule like the master branch, and I change the default branch with the main branch.

I ran the workflow on the main branch: https://github.com/process-analytics/github-actions-playground/actions/runs/3764866768. The job works fine ✅

[csouchet]

To test, I deleted the rule of the master branch on https://github.com/process-analytics/github-actions-playground.

I ran the workflow on the main branch: https://github.com/process-analytics/github-actions-playground/actions/runs/3764905611. The job works fine ✅

[csouchet]

On https://github.com/process-analytics/bpmn-visualization-R, the rule Do not allow bypassing the above settings was missing.

[csouchet]

To test, I added the rules Require a pull request before merging, Require approvals, Require status checks to pass before merging and Require branches to be up to date before merging on the main branch of https://github.com/process-analytics/github-actions-playground.

I ran the workflow on the main branch: https://github.com/process-analytics/github-actions-playground/actions/runs/3765137238/jobs/6400302241. The job works fine ✅

[csouchet]

To test, I updated the version of Ubuntu (ubuntu-22.04) on the main branch, like https://github.com/process-analytics/bpmn-visualization-R.

I ran the workflow on the main branch: https://github.com/process-analytics/github-actions-playground/actions/runs/3765998102. The job works fine ✅

[csouchet]

To test, I renamed the master branch in old_master on origin.

I ran the workflow on the main branch: https://github.com/process-analytics/github-actions-playground/actions/runs/3766043340. The job works fine ✅

[csouchet]

The access token used for benjefferies/branch-protection-bot@1.0.7 has the same rights in https://github.com/process-analytics/github-actions-playground and https://github.com/process-analytics/bpmn-visualization-R.

[csouchet]

I wonder if the problem is the capitalization in the repository name: bpmn-visualization-R.

[csouchet]

❌ When I tried to get the protection of the main branch via Rest API, following https://docs.github.com/en/rest/branches/branch-protection?apiVersion=2022-11-28#get-branch-protection, I had the following error:

Note: I generated a new token with the same rights as GH_RELEASE_TOKEN, with access on https://github.com/process-analytics/bpmn-visualization-R.

❌ Same with bpmn-visualization-r

[csouchet]

I tried to recreate the main rule, like it was.

❌ I always had the same error.

[csouchet]

I checked the rules protection from https://github.com/process-analytics/bpmn-visualization-js and https://github.com/process-analytics/bpmn-visualization-R. They are the same, but on https://github.com/process-analytics/bpmn-visualization-js, it's on the master branch.

✅ When I do the same test with the master branch of https://github.com/process-analytics/bpmn-visualization-js and the same token, I had the following result:

[csouchet]

✅ When I do the same test with the main branch of https://github.com/process-analytics/github-actions-playground and the same token, I had the following result:

[csouchet]

I renamed the main branch to master on https://github.com/process-analytics/bpmn-visualization-R.

❌ I always had the same error.