-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AsyncElegantOTA #118
Add AsyncElegantOTA #118
Conversation
Cool! 👍 Build is using the library now but there is still a compile error, please see the build log. |
@probonopd Right. I am working on a Fix. |
@probonopd It's saying Is that due to, functions declared under it? |
Looks like it. Feel free to move. |
@probonopd Passed ESP8266 Build. ESP32 Build is causing some problem due to a script error in travis.yml . Please take a look. |
Maybe need to add I will try to add this. Seems to be a known issue: |
So this was not sufficient, still getting |
Maybe you can figure this out.. i have no idea why it's not getting Hash.h |
Yes, but give me some time. Thanks until here, great PR |
No problem. |
Yay! Looks like we have a winner. 👍 Do they work for you, including OTA?
(Links available for 14 days) |
@probonopd I will it check today. 👍 |
Surprisingly, It compiles for me without that library.Try latest release of ESP32 Arduino Core. |
I just checked the build logs. It is using 75% of Sketch space. Is there any space left for an OTA? 🤦♂ . |
Also, we need a link to |
I will update ElegantOTA Webpage by tomorrow. Thanks for testing.
…On Sat, 4 May 2019, 2:41 pm probonopd, ***@***.***> wrote:
On the ESP32, getting
[image: failed]
<https://user-images.githubusercontent.com/2480569/57176827-7c179180-6e4c-11e9-9a64-6a9522216205.png>
but the update nevertheless seems to have worked. I have the updated
firmware on the machine afterwards.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGK4NSEWAKGJXKPH5A7TXXLPTVHKRANCNFSM4HJ3UDFQ>
.
|
Fixed webpage and tested on my ESP32. Thanks! |
Don't know why it is failing, perhaps an intermittent issue? |
I think it's failing due to some change in esp8266 arduino package.json
which arduino gets for the board manager.
…On Sat, 11 May 2019, 3:33 pm probonopd, ***@***.***> wrote:
Don't know why it is failing, perhaps an intermittent issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGK4NSGRWIJSH3SKVHBS6S3PU2KYNANCNFSM4HJ3UDFQ>
.
|
http://arduino.esp8266.com/stable/package_esp8266com_index.json gives in Firefox:
|
Yup. It's a problem with their package.json
Can you test it by compiling on your pc for esp8266?
We can merge, if it compiles successfully.
…On Sat, 11 May 2019, 3:42 pm probonopd, ***@***.***> wrote:
http://arduino.esp8266.com/stable/package_esp8266com_index.json gives in
Firefox:
SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the
JSON data
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGK4NSA4PBR45FR2T23A4OLPU2LXDANCNFSM4HJ3UDFQ>
.
|
I never compile anything locally. It needs to pass the automated builds... |
Okay. Then we can wait till esp8266 arduino core fixes itself.
…On Sat, 11 May 2019, 3:49 pm probonopd, ***@***.***> wrote:
I never compile anything locally. It needs to pass the automated builds...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGK4NSFRBEOGJ7V4JJO3U43PU2MSBANCNFSM4HJ3UDFQ>
.
|
The build is working now. Do we not get the red arrow anymore? (Couldn't test myself yet) |
Nope. I have updated AsyncElegantOTA. It shows the |
Can we merge it now? |
I did not have a chance to test it on ESP8266 and ESP32 yet, sorry. Do we have a link to the firmware update page from the main frontpage? |
I will add that |
Done |
If you have successfully tested updating on ESP8266 and ESP32 hardware with no red arrows or other errors, then I think we can merge? |
Sure.
…On Mon, 13 May 2019, 11:08 pm probonopd, ***@***.***> wrote:
If you have successfully tested updating on ESP8266 and ESP32 hardware
with no red arrows or other errors, then I think we can merge?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#118?email_source=notifications&email_token=AGK4NSAZOYGY5WWCBWSKXN3PVGRRLA5CNFSM4HJ3UDF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVJA72I#issuecomment-491917289>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGK4NSAQTJDMW5JT3ZKKV5LPVGRRLANCNFSM4HJ3UDFQ>
.
|
Add AsyncElegantOTA to perform OTA's Elegantly.