Fix types definition for decorator #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## alpha #529 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 127 127
Branches 21 21
=========================================
Hits 127 127 Continue to review full report at Codecov.
|
|
Also fixed the import in the README |
|
🎉 This PR is included in version 5.0.0-alpha.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the types definition for the decorator were not changed when the decorator was excluded from the index file. So I removed the export of Socket from index and moved it to another definition file.
With this article, I figured out how to provide the definition file for the submodule: https://dev.to/binjospookie/exports-in-package-json-1fl2
Before this, I was not able to use Socket with TypeScript. The Import
import Socket from 'vue-socket.io-extended/decorator';was not working and IDE mentioned that there was no module found namedvue-socket.io-extended/decorator.The change to package.json was needed because IDE would mention to use import
import Socket from 'vue-socket.io-extended/types/decorator';which is working in IDE but not when compiling as the JS import is wrong.#489 (comment)