Does it still need nightly Rust?

[elfmimi]

Is this true? I think I'm building with a stable version of Rust and it seems to be going all alright.

flash-algorithm-template/README.md

Line 40 in 8ee461a

Building requires nightly Rust.

[Yatekii]

Hmm I remember vaguely that it was required but if it works without nightly, I am good to remove the comment :) I think there was something about nighly traits/async?

[elfmimi]

looking around, I found this.

flash-algorithm-template/.cargo/config.toml

Lines 9 to 12 in 8ee461a

	# Code-size optimizations.
	# This requires nightly atm.
	# "-Z",
	# "trap-unreachable=no",

I guess that the fact that it is commented out means that there was an intention to switch from nightly to stable at some point in the past.

[elfmimi]

Probably this is the reason.
https://github.com/probe-rs/flash-algorithm/blob/dcf3f7195cdfe7b8dd90ed6bf5d72e7e655cfbf0/src/lib.rs#L15-L22

#[cfg(all(not(test), feature = "panic-handler"))]
#[panic_handler]
fn panic(_info: &core::panic::PanicInfo) -> ! {
    unsafe {
        core::arch::asm!("udf #0");
        core::hint::unreachable_unchecked();
    }
}

Inline assembly (asm!) has been stabilized at Rust 1.59 , Feb. 2022 .

edited: noticed that both creates are way younger than that.

[Tiwalun]

looking around, I found this.

flash-algorithm-template/.cargo/config.toml

Lines 9 to 12 in 8ee461a

	# Code-size optimizations.
	# This requires nightly atm.
	# "-Z",
	# "trap-unreachable=no",

I guess that the fact that it is commented out means that there was an intention to switch from nightly to stable at some point in the past.

I think this was the reason, in the initial commit this was not commented out, so it actually required nightly.

[elfmimi]

It's an awfully trivial change but I created a PR anyway.