Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quic go-routine leak in tests #56

Merged
merged 3 commits into from
Oct 6, 2023
Merged

fix: quic go-routine leak in tests #56

merged 3 commits into from
Oct 6, 2023

Conversation

dennis-tra
Copy link
Contributor

By only enabling the TCP transport we won't leak quic-reuse goroutines in our tests: libp2p/go-libp2p#2514

Relates to: #34

We can't configure the leveldb timeout, so we're leaking one goroutine after each test for ~1s.

Then I found that there's another goroutine still dangling around after each test which could be closed with:

import (
	log "github.com/ipfs/go-log/writer"
)

func ... {
   log.WriterGroup.Close()
}

@dennis-tra dennis-tra merged commit 997ed98 into main Oct 6, 2023
7 checks passed
@dennis-tra dennis-tra deleted the issue-34 branch October 6, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants