Skip to content

Fix bugs in inference #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix bugs in inference #164

merged 1 commit into from
Sep 12, 2024

Conversation

georgematheos
Copy link
Collaborator

@nishadgothoskar this seems to remove the NaN bugs. Inference seems like it works alright, but it does get off eventually -- and I think it isn't honing in closely enough to the right pose. So I think it is a good next step to do as you suggested and add several coarse-to-fine steps.

@georgematheos
Copy link
Collaborator Author

The inference bug arose because the function to propose vertex colors given the other attributes assumed that the latent point projected to a pixel in the image -- but sometimes it would be called on a latent point that did not hit any pixel. The fix here adds code to branch on whether the observed_rgbd is valid or invalid (ie. the token for when the latent point doesn't hit a pixel).

@georgematheos georgematheos merged commit 335514f into gen3d Sep 12, 2024
6 of 7 checks passed
@georgematheos georgematheos deleted the gm/gen3d/inference5 branch September 12, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant