-
Notifications
You must be signed in to change notification settings - Fork 66
Modernize python to 3.10, introduce ruff formating #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@prkumar can you re-enable the tests to be sure I didn't break anything? I would like to also move from |
|
I ran the tests in python3.10 and these are the only ones failing, but as I don't uderstand well this part of the internals I will need some help to fix them: |
|
Hi, @leiserfg - Thanks for this great PR! I tried to reenable the Travis CI builds, but ultimately decided to migrate our CI pipeline to GitHub Actions. Could you try rebasing this PR onto master? |
|
Hey, @leiserfg - Was trying to be helpful and pushed a change to the PR to fix a merge conflict I caused. Seeing now that you also force-pushed a change to fix the conflict. Sorry if my change caused any hassle! I'll hold off on pushing any additional changes. |
|
👍 I just rebased as you toldme, I think you better do there what you need, I don't care if that removes my authorship on the commits as long as that leads to a better uplink. |
|
Do you know what changes we need to fix the tests? I'm guessing that Also, any preference for keeping tox or moving to something else? I know you mentioned switching from |
|
There is https://github.com/tox-dev/tox-uv that allows using the same tox config and leveraging uv for creating the environments. But I think we better keep it as is by now so we can focus on passing the tests and then I can do the changes to uv. |
|
🤦 I forgot that I already added UV. Then let me check if I can make the test run. |
|
Sounds good! Let me know if you need any help with getting the tests to run. |
|
@prkumar done. As I mentioned a couple of tests are failing but I don't know that part of the code so I'm not sure how to fix them. |
|
@leiserfg - Fixed the tests! |
|
Changes look good to me! TY! Feel free to merge :) |
Fixes # .
Changes proposed in this pull request:
Attention: @prkumar