Skip to content

Update asyncio example to use async/await syntax in Python 3.7 or later #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prkumar merged 1 commit into from
Feb 27, 2021
Merged

Update asyncio example to use async/await syntax in Python 3.7 or later #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions examples/async-requests/asyncio_example.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""
Example of using Uplink with aiohttp for non-blocking HTTP requests.
This should work on Python 3.4 and above.
This should work on Python 3.7 and above.
"""
import asyncio
import uplink
Expand All @@ -9,11 +9,10 @@
from github import BASE_URL, GitHub


@asyncio.coroutine
def get_contributors(full_name):
async def get_contributors(full_name):
print("Getting GitHub repository `{}`".format(full_name))
response = yield from gh_async.get_contributors(*full_name.split("/"))
json = yield from response.json()
response = await gh_async.get_contributors(*full_name.split("/"))
json = await response.json()
print("response for {}: {}".format(full_name, json))
return json

Expand All @@ -34,4 +33,4 @@ def get_contributors(full_name):
# Concurrently fetch the contributors for those repositories.
futures = [get_contributors(repo["full_name"]) for repo in repos]
loop = asyncio.get_event_loop()
loop.run_until_complete(asyncio.wait(futures))
loop.run_until_complete(asyncio.gather(*futures))