Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite6 #15

Merged
merged 10 commits into from
Dec 19, 2024
Merged

Vite6 #15

merged 10 commits into from
Dec 19, 2024

Conversation

mrginglymus
Copy link
Contributor

@mrginglymus mrginglymus commented Dec 11, 2024

This is an extension of #14, because I'd like to use this myself again.

I had to rollback typescript as pnpm doesn't seem to like typescript 5.6 (more of a yarn person myself)...tsc was throwing all lkinds of weird errors that a rollback to 5.5.4 (or a switch to yarn) fixed. I then noticed that tsc wasn't run as part of the CI job, so added that.

The missing filename I think is trivial; the test harness doesn't provide a closest package.json, so let's just provide the static name as suggested. I then took the commit from #14, massaged the types, and the tests seem to pass!

closes #14
fixes #13

@mrginglymus mrginglymus marked this pull request as ready for review December 11, 2024 18:38
@privatenumber
Copy link
Owner

Thanks, I'll try to review over the weekend!

@mrginglymus
Copy link
Contributor Author

Hmm - I've just tried running this against storybook:

      at environment.moduleGraph.getModuleById (<snip>\.yarn\__virtual__\vite-css-modules-virtual-37f24d10ae\3\AppData\Local\Yarn\Berry\cache\vite-css-modules-file-0ae5b0aca7-10c0.zip\node_modules\vite-css-modules\dist\index.cjs:1079:24) (x599)
16:38:41 [vite] Internal server error: Maximum call stack size exceeded

well that's not ideal :D I'll see if I can drill into it tomorrow

@mrginglymus
Copy link
Contributor Author

I've been unable to reproduce this since in storybook

@privatenumber privatenumber merged commit 9b7c639 into privatenumber:develop Dec 19, 2024
1 check passed
@privatenumber
Copy link
Owner

Thank you @mrginglymus & @skewballfox !

@privatenumber
Copy link
Owner

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite 6: TypeError: vite:css-analysis plugin transform is not a function
3 participants