-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite6 #15
Merged
Merged
Vite6 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks, I'll try to review over the weekend! |
Hmm - I've just tried running this against storybook:
well that's not ideal :D I'll see if I can drill into it tomorrow |
I've been unable to reproduce this since in storybook |
Thank you @mrginglymus & @skewballfox ! |
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of #14, because I'd like to use this myself again.
I had to rollback typescript as pnpm doesn't seem to like typescript 5.6 (more of a yarn person myself)...
tsc
was throwing all lkinds of weird errors that a rollback to 5.5.4 (or a switch to yarn) fixed. I then noticed thattsc
wasn't run as part of the CI job, so added that.The missing filename I think is trivial; the test harness doesn't provide a closest package.json, so let's just provide the static name as suggested. I then took the commit from #14, massaged the types, and the tests seem to pass!
closes #14
fixes #13