Migrate to tracing crate
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracing is a superset of features we're using currently (print to stderr, verbosity, format) and is required to instrument MPC helpers with telemetry required to understand the performance of it and different protocols we'll be experimenting with. This change also adds some pretty basic tracing of HTTP requests by using `tower-http` crate. `stderrlog` crate is removed as we no longer need to use it. Besides that, it has a security advisory against it ``` Crate: time Version: 0.1.44 Title: Potential segfault in the time crate Date: 2020-11-18 ID: RUSTSEC-2020-0071 URL: https://rustsec.org/advisories/RUSTSEC-2020-0071 Solution: Upgrade to >=0.2.23 Dependency tree: time 0.1.44 └── chrono 0.4.19 └── stderrlog 0.5.3 └── raw-ipa 0.1.0 error: 1 vulnerability found! ```
akoshelev
force-pushed
the
helper-service
branch
from
dcbe6cb
to
430f30b
Compare
|
LGTM |
martinthomson
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Tracing crate has all features we're using currently (print to stderr, verbosity, format) and is required to instrument MPC helpers with telemetry required to understand the performance of it and different protocols we'll be experimenting with.
This change also adds some pretty basic tracing of HTTP requests by using
tower-httpcrate.stderrlogcrate is removed as we no longer need to use it. Besides that, it has a security advisory against itTesting
terminal window 1
cargo run --features self-signed-certs --bin helper -- -s https -p 3000 -vvv helper-service 6d5c2f5 Finished dev [unoptimized + debuginfo] target(s) in 0.31s Running `target/debug/helper -s https -p 3000 -vvv` INFO raw_ipa::cli::verbosity: Logging setup at level debug INFO helper: listening to https://127.0.0.1:3000 DEBUG rustls::server::hs: decided upon suite TLS13_AES_256_GCM_SHA384 DEBUG hyper::proto::h1::io: parsed 5 headers DEBUG hyper::proto::h1::conn: incoming body is empty DEBUG request{method=GET uri=/echo?foo=bar version=HTTP/1.1}: tower_http::trace::on_request: started processing request DEBUG request{method=GET uri=/echo?foo=bar version=HTTP/1.1}: tower_http::trace::on_response: finished processing request latency=0 ms status=200 DEBUG hyper::proto::h1::io: flushed 270 bytes DEBUG hyper::proto::h1::conn: read eof DEBUG rustls::conn: Sending warning alert CloseNotifyterminal window 2
wget -q -nv "https://127.0.0.1:3000/echo?foo=bar" --no-check-certificate -O -