Enable concurrency testing #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug inside the test sending left part of the share twice
Now that they are green, we can run them as part of CI workflow
They don't take long to finish. I expect many failures because folks will forget to add `not(feature = "shuttle")` to their test modules.
martinthomson
approved these changes
Jan 8, 2023
src/tests/protocol.rs
Outdated
Comment on lines
9
to
12
| fn semi_honest_ipa() { | ||
| shuttle::check_random( | ||
| || { | ||
| shuttle::future::block_on(async { |
There was a problem hiding this comment.
fair enough, I think it can be improved
There was a problem hiding this comment.
I was proven wrong by the formatter :(
src/tests/protocol.rs
Outdated
| shuttle::check_random( | ||
| || { | ||
| shuttle::future::block_on(async { | ||
| const BATCHSIZE: usize = 20; |
There was a problem hiding this comment.
Would a smaller batch allow you to increase the number of iterations?
There was a problem hiding this comment.
yep, setting it to 5 allowed me to have 6 iterations. still quite small but better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally found the bug that was blocking shuttle tests. The issue outlined in #256 was fixed in
#363 but there was another bug inside the concurrency test itself. This change fixes it and enables concurrency testing as part of PR workflow approval.
It also adds a test for semi-honest IPA but given that it is incredibly slow, it only runs it for 2 iterations. Once we improve the IPA latency, number of iterations can be increased.