Update how-to-enroll.md, remove same-site explainer link #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The explanation for where attestations json file should be placed is confusing. Namely the link we propose to be removed leads to a page where "same-site" is explained but the file cannot be placed on the same site as we were notified during the enrollment process. If you enroll the site: example.com, the file should be placed at example.com/.well-known/privacy-sanbox-attestations.json. Putting it on a same-site subdomain will fail the automatic tests. For example: privacy-sandbox.example.com/.well-known/privacy-sanbox-attestations.json.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explanation for where attestations json file should be placed is confusing.
Namely the link we propose to be removed leads to a page where "same-site" is explained but the file cannot be placed on the same site as we were notified during the enrollment process.
If you enroll the site: example.com, the file should be placed at example.com/.well-known/privacy-sanbox-attestations.json.
Putting it on a same-site subdomain will fail the automatic tests. For example: privacy-sandbox.example.com/.well-known/privacy-sanbox-attestations.json.