Merge pull request #7 from privacybydesign/fix-inline-styling

Fix inline styling
privacybydesign · Mar 27, 2023 · da05c06 · da05c06
2 parents 23d26b9 + 0396132
commit da05c06
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 32 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/plugins/yivi-web/dom-manipulations.js b/plugins/yivi-web/dom-manipulations.js
@@ -264,8 +264,8 @@ module.exports = class DOMManipulations {
               <input inputmode="numeric" pattern="\\d" maxlength="1" required />
               <input inputmode="numeric" pattern="\\d" maxlength="1" required />
             </div>
-            <input type="submit" style="display: none" />
-            <div class="yivi-web-pairing-loading-animation" style="visibility: hidden">
+            <input type="submit" />
+            <div class="yivi-web-pairing-loading-animation">
                 <i></i><i></i><i></i><i></i><i></i><i></i><i></i><i></i><i></i>
             </div>
             <p><a data-yivi-glue-transition="cancel">${this._translations.cancel}</a></p>

diff --git a/yivi-css/src/components/yivi-pairing-form.scss b/yivi-css/src/components/yivi-pairing-form.scss
@@ -100,6 +100,7 @@
 
   .yivi-web-pairing-loading-animation {
     @extend .yivi-web-loading-animation;
+    visibility: hidden;
     margin: 10px 0;
   }
 
@@ -120,4 +121,8 @@
       font-size: 1em;
     }
   }
+
+  input[type='submit'] {
+    display: none;
+  }
 }
diff --git a/yivi-frontend/package-lock.json b/yivi-frontend/package-lock.json