Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

Add workflow to automatically assign PR reviewers #428

Closed
wants to merge 1 commit into from

Conversation

CPerezz
Copy link
Contributor

@CPerezz CPerezz commented Apr 5, 2022

As stated in #423, it would be nice if reviews could be assigned
automatically to a group of reviwers so that the reviewing process is
more agile.

Closes #423

As stated in #423, it would be nice if reviews could be assigned
automatically to a group of reviwers so that the reviewing process is
more agile.

Closes #423
@CPerezz
Copy link
Contributor Author

CPerezz commented Apr 5, 2022

Currently affected by a bug: cli/cli#4844

I'm not even sure this PR solved will solve the issues as the main issue is that the token does not provide this permissions directly...

CPerezz added a commit that referenced this pull request Apr 5, 2022
Since the solution #428 is impossible to implement as a bug affecting
the gh actions prevents it.
An alternative to automatically assign reviews for the reviewing team is
to use a CODEOWNERS file.

So this PR adds this file configured to assign all reviews to
`appliedzkp/zkevm-reviewers` and also Miha specifically to any state
circuit PR.

Resolves: #423
CPerezz added a commit that referenced this pull request Apr 5, 2022
Since the solution #428 is impossible to implement as a bug affecting
the gh actions prevents it.
An alternative to automatically assign reviews for the reviewing team is
to use a CODEOWNERS file.

So this PR adds this file configured to assign all reviews to
`appliedzkp/zkevm-reviewers` and also Miha specifically to any state
circuit PR.

Resolves: #423
CPerezz added a commit that referenced this pull request Apr 5, 2022
Since the solution #428 is impossible to implement as a bug affecting
the gh actions prevents it.
An alternative to automatically assign reviews for the reviewing team is
to use a CODEOWNERS file.

So this PR adds this file configured to assign all reviews to
`appliedzkp/zkevm-reviewers` and also Miha specifically to any state
circuit PR.

Resolves: #423
CPerezz added a commit that referenced this pull request Apr 5, 2022
Since the solution #428 is impossible to implement as a bug affecting
the gh actions prevents it.
An alternative to automatically assign reviews for the reviewing team is
to use a CODEOWNERS file.

So this PR adds this file configured to assign all reviews to
`appliedzkp/zkevm-reviewers` and also Miha specifically to any state
circuit PR.

Resolves: #423
@CPerezz
Copy link
Contributor Author

CPerezz commented Apr 5, 2022

Superset by #429

@CPerezz CPerezz closed this Apr 5, 2022
CPerezz added a commit that referenced this pull request Apr 5, 2022
Since the solution #428 is impossible to implement as a bug affecting
the gh actions prevents it.
An alternative to automatically assign reviews for the reviewing team is
to use a CODEOWNERS file.

So this PR adds this file configured to assign all reviews to
`appliedzkp/zkevm-reviewers` and also Miha specifically to any state
circuit PR.

Resolves: #423
@0xmountaintop
Copy link
Collaborator

0xmountaintop commented Apr 6, 2022

@0xmountaintop
Copy link
Collaborator

@0xmountaintop
Copy link
Collaborator

My point is that, seems adding @appliedzkp/zkevm-reviewers in CODEOWNERS only request 1 reviewer? (except zkevm-circuits/src/state_circuit/ and zkevm-circuits/src/state_circuit.rs)

see #434 and #435 for an example

but https://github.com/marketplace/actions/auto-request-review allows randomly selecting n reviewers (n can be configured.)
and also allow selecting specific reviewer for specific files.

seems exactly what we need.

1 similar comment
@0xmountaintop
Copy link
Collaborator

My point is that, seems adding @appliedzkp/zkevm-reviewers in CODEOWNERS only request 1 reviewer? (except zkevm-circuits/src/state_circuit/ and zkevm-circuits/src/state_circuit.rs)

see #434 and #435 for an example

but https://github.com/marketplace/actions/auto-request-review allows randomly selecting n reviewers (n can be configured.)
and also allow selecting specific reviewer for specific files.

seems exactly what we need.

@CPerezz CPerezz deleted the review_assig branch April 7, 2022 08:02
@CPerezz
Copy link
Contributor Author

CPerezz commented Apr 7, 2022

Hi @HAOYUatHZ

My point is that, seems adding @appliedzkp/zkevm-reviewers in CODEOWNERS only request 1 reviewer?

This is done in porpuse. The group is configuref via GitHub and assigns n reviewers automatically.
It was set to one now so that we could test it.

My plan now is to add @icemelon too and if that works, add some Scroll members so that each PR gets assigned 2 reviewers. 1 from Scroll and one from appliedzkp

@0xmountaintop
Copy link
Collaborator

Hi @HAOYUatHZ

My point is that, seems adding @appliedzkp/zkevm-reviewers in CODEOWNERS only request 1 reviewer?

This is done in porpuse. The group is configuref via GitHub and assigns n reviewers automatically.

It was set to one now so that we could test it.

My plan now is to add @icemelon too and if that works, add some Scroll members so that each PR gets assigned 2 reviewers. 1 from Scroll and one from appliedzkp

I see.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a workflow to automatically select reviewers for PRs
2 participants