-
Notifications
You must be signed in to change notification settings - Fork 852
Add workflow to automatically assign PR reviewers #428
Conversation
Currently affected by a bug: cli/cli#4844 I'm not even sure this PR solved will solve the issues as the main issue is that the token does not provide this permissions directly... |
Since the solution #428 is impossible to implement as a bug affecting the gh actions prevents it. An alternative to automatically assign reviews for the reviewing team is to use a CODEOWNERS file. So this PR adds this file configured to assign all reviews to `appliedzkp/zkevm-reviewers` and also Miha specifically to any state circuit PR. Resolves: #423
Since the solution #428 is impossible to implement as a bug affecting the gh actions prevents it. An alternative to automatically assign reviews for the reviewing team is to use a CODEOWNERS file. So this PR adds this file configured to assign all reviews to `appliedzkp/zkevm-reviewers` and also Miha specifically to any state circuit PR. Resolves: #423
Since the solution #428 is impossible to implement as a bug affecting the gh actions prevents it. An alternative to automatically assign reviews for the reviewing team is to use a CODEOWNERS file. So this PR adds this file configured to assign all reviews to `appliedzkp/zkevm-reviewers` and also Miha specifically to any state circuit PR. Resolves: #423
Since the solution #428 is impossible to implement as a bug affecting the gh actions prevents it. An alternative to automatically assign reviews for the reviewing team is to use a CODEOWNERS file. So this PR adds this file configured to assign all reviews to `appliedzkp/zkevm-reviewers` and also Miha specifically to any state circuit PR. Resolves: #423
Superset by #429 |
Since the solution #428 is impossible to implement as a bug affecting the gh actions prevents it. An alternative to automatically assign reviews for the reviewing team is to use a CODEOWNERS file. So this PR adds this file configured to assign all reviews to `appliedzkp/zkevm-reviewers` and also Miha specifically to any state circuit PR. Resolves: #423
why not try these? |
why not try these? |
My point is that, seems adding @appliedzkp/zkevm-reviewers in CODEOWNERS only request 1 reviewer? (except zkevm-circuits/src/state_circuit/ and zkevm-circuits/src/state_circuit.rs) see #434 and #435 for an example but https://github.com/marketplace/actions/auto-request-review allows randomly selecting seems exactly what we need. |
1 similar comment
My point is that, seems adding @appliedzkp/zkevm-reviewers in CODEOWNERS only request 1 reviewer? (except zkevm-circuits/src/state_circuit/ and zkevm-circuits/src/state_circuit.rs) see #434 and #435 for an example but https://github.com/marketplace/actions/auto-request-review allows randomly selecting seems exactly what we need. |
Hi @HAOYUatHZ
This is done in porpuse. The group is configuref via GitHub and assigns My plan now is to add @icemelon too and if that works, add some Scroll members so that each PR gets assigned 2 reviewers. 1 from Scroll and one from appliedzkp |
I see. |
As stated in #423, it would be nice if reviews could be assigned
automatically to a group of reviwers so that the reviewing process is
more agile.
Closes #423