Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

Implementation ExecutionState::STOP #419

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Implementation ExecutionState::STOP #419

merged 3 commits into from
Jul 4, 2022

Conversation

han0110
Copy link
Contributor

@han0110 han0110 commented Apr 2, 2022 •
edited
Loading

This PR aims to implement ExecutionState::STOP. For spec, please refer to privacy-scaling-explorations/zkevm-specs#100.

It also resolves #464 by removing the incomplete trace testing used in COPYTOMEMORY and COPYCODETOMEMORY because they should be covered by CALLDATACOPY and CODECOPY.

TODO

Broken tests

Currently some of tests using hand-crafted testing witness (instead of using CircuitInputBuilder) are failed by this PR, those unfixed include:

Opcode fetching out of range

@github-actions github-actions bot added crate-bus-mapping Issues related to the bus-mapping workspace member crate-keccak Issues related to the keccak workspace member T-opcode Type: opcode-related and focused PR/Issue crate-zkevm-circuits Issues related to the zkevm-circuits workspace member labels Apr 2, 2022
@pinkiebell pinkiebell mentioned this pull request Apr 6, 2022
Closed
This was referenced Apr 6, 2022
Merged
Closed
@adria0 adria0 mentioned this pull request Apr 8, 2022
Closed
11 tasks
This was referenced Apr 12, 2022
Merged
Closed
@github-actions github-actions bot removed crate-keccak Issues related to the keccak workspace member T-opcode Type: opcode-related and focused PR/Issue labels Apr 14, 2022
@han0110 han0110 mentioned this pull request Apr 14, 2022
Merged
@z2trillion z2trillion mentioned this pull request Apr 14, 2022
Merged
@ed255 ed255 mentioned this pull request May 3, 2022
Closed
This was referenced May 4, 2022
Closed
Closed
@ed255 ed255 mentioned this pull request Jun 15, 2022
Closed
48 tasks
ed255
ed255 reviewed Jun 23, 2022
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review round. I'm missing review of:

  • zkevm-circuits/src/evm_circuit/step.rs
  • zkevm-circuits/src/evm_circuit/util/common_gadget.rs
  • zkevm-circuits/src/evm_circuit/witness.rs

Overall looks good! I've added minor comments and suggestions.

ed255
ed255 approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. LGTM!

@han0110 han0110 marked this pull request as ready for review July 1, 2022 15:12
DreamWuGit
DreamWuGit approved these changes Jul 4, 2022
View reviewed changes
Copy link
Collaborator

@DreamWuGit DreamWuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only left some classifications!

@han0110 han0110 merged commit d59be68 into privacy-scaling-explorations:main Jul 4, 2022
@han0110 han0110 deleted the feature/stop branch July 4, 2022 08:42
zemse pushed a commit to zemse/zkevm-circuits that referenced this pull request Mar 22, 2023
@silathdiir
Implement circuit for ErrorOutOfGasSHA3 state (privacy-scaling-expl…
4b071a6 
…orations#419)

* Implement circuit for `ErrorOutOfGasSHA3` state.

* Add `MemoryExpandedAddressGadget` to support memory offset plus length greater than `0x1FFFFFFFE0`.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DreamWuGit DreamWuGit DreamWuGit approved these changes

@ed255 ed255 ed255 approved these changes

Assignees
No one assigned
Labels
crate-bus-mapping Issues related to the bus-mapping workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable first and last step ExecutionState check
3 participants
@han0110 @DreamWuGit @ed255