feat: add sstore circuit

[0xmountaintop]

No description provided.

[ed255]

Overall looks good! Thanks for working on this.

Nevertheless I see how tricky it is to calculate gas cost and refund values for this opcode. I would be more confident reviewing this if the SSTORE was implemented in the bus-mapping (like I suggest in a comment). So that the external tracer with the circuit input builder can be used, and then we can test all the different scenarios with the gas cost and refund value set by geth to test the correctness of the implementation.

Let me know your plans on implementing the SSTORE in the bus-mapping :)

[0xmountaintop]

Hi @ed255 !

1. fix stack_pointer in: ff39793
2. update comments: 456bd1a (Refund Value in units of gas seems fine here. No need for Refund Value in gwei).
3. Yes, I do plan to implement the bus-mapping for sstore. And like feat: add sload op (bus-mapping version) #347, I believe we will need Modularize mock crate for easier and more customizable testing setup generation #349 gets merged first. Otherwise I cannot test is_persist and is_warm conveniently. So, should I turn this PR into draft, and then work on it after Modularize mock crate for easier and more customizable testing setup generation #349 being merged?

[ed255]

3. Yes, I do plan to implement the bus-mapping for sstore. And like feat: add sload op (bus-mapping version) #347, I believe we will need [WIP] Modularize mock crate for easier and more customizable testing setup generation #349 gets merged first. Otherwise I cannot test is_persist and is_warm conveniently. So, should I turn this PR into draft, and then work on it after [WIP] Modularize mock crate for easier and more customizable testing setup generation #349 being merged?

Thanks for pointing out that the bus-mapping implementation is blocked by #349
In that case I think it's OK to proceed without the bus-mapping implementation in order to avoid blocking this PR :)
I've opened an issue to track the bus-mapping implementation at #388

Also let's wait for a second review before merging!

[ed255]

LGTM!

[CPerezz]

LGTM!! Nice job!!
Good catch with the stack positions too @ed255

[ed255]

@HAOYUatHZ once the PR is rebased with main and the conflicts are resolved, we can merge this :)