This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Circuit for opcode SELFBALANCE #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-bus-mapping
|
@scroll-dev Mason Liang Can we do a rebase for this? |
ed255
suggested changes
Feb 14, 2022
z2trillion
force-pushed
the
feat/opcode-selfbalance
branch
from
5906508 to
216d31a
Compare
github-actions
bot
removed
the
crate-bus-mapping
78 tasks
ed255
reviewed
Feb 15, 2022
|
@z2trillion #292 has been merged! Do you plan on updating this PR to implement the SELFBALANCE in the bus mapping? Or do you prefer doing that in another PR? |
This reverts commit ecc000f.
z2trillion
force-pushed
the
feat/opcode-selfbalance
branch
from
cb07f2c to
f3375e0
Compare
github-actions
bot
added
the
crate-bus-mapping
|
@ed255, I've rebased and added the bus mapping. |
ed255
approved these changes
Feb 24, 2022
|
@z2trillion There seems to be a linting error coming from clippy. |
z2trillion
force-pushed
the
feat/opcode-selfbalance
branch
from
522614a to
9441677
Compare
|
@ed255 it should be fixed now. |
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the SelfbalanceGadget for opcode
SELFBALANCE.Specs: privacy-scaling-explorations/zkevm-specs#113
Will update the bus mapping for SELFBALANCE once #292 is merged in upstream.