This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Circuit for opcode TIMESTAMP #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-bus-mapping
ed255
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
LGTM! Please take a look at the note I wrote about using cb.query_rlc().
Also let's wait for privacy-scaling-explorations/zkevm-specs#105 to be merged before merging this PR
| @@ -111,8 +110,8 @@ fn fn_gen_associated_ops(opcode_id: &OpcodeId) -> FnGenAssociatedOps { | |||
| // OpcodeId::RETURNDATACOPY => {}, | |||
| // OpcodeId::EXTCODEHASH => {}, | |||
| // OpcodeId::BLOCKHASH => {}, | |||
| OpcodeId::COINBASE => Coinbase::gen_associated_ops, | |||
| // OpcodeId::TIMESTAMP => {}, | |||
| OpcodeId::COINBASE => StackOnlyOpcode::<0>::gen_associated_ops, | |||
barryWhiteHat
added
benchmarks: ALL
z2trillion
force-pushed
the
feat/opcode-timestamp
branch
from
9463dc9 to
7518c31
Compare
…nto feat/opcode-timestamp
z2trillion
force-pushed
the
feat/opcode-timestamp
branch
from
6a10996 to
f83788a
Compare
|
@ed255 Could you take a look again? |
ed255
approved these changes
Feb 2, 2022
|
Thanks for the work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the TimestampGadget for opcode TIMESTAMP.
Specs: scroll-tech/zkevm-specs#31
Other changes:
StackOnlyOpcode::<0>for COINBASE bus mapping.BlockContext.