Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

tech-debt: Re-enable end_tx tests that depended on SSTORE #1111

Closed
@CPerezz

Description

@CPerezz

In #312 we left some tech debt as some tests for EndTx could not be done due to SSTORE not being implemented.

Now that it is, we should be able to brind them back and pay this tech debt.

See:

fn end_tx_gadget_simple() {
// TODO: Enable this with respective code when SSTORE is implemented.
// Tx with non-capped refund
// test_ok(vec![mock_tx(
// address!("0x00000000000000000000000000000000000000fe"),
// Some(27000),
// None,
// )]);
// Tx with capped refund
// test_ok(vec![mock_tx(
// address!("0x00000000000000000000000000000000000000fe"),
// Some(65000),
// None,
// )]);

Metadata

Metadata

Assignees

Labels

T-tech-debtType: tech-debt generated or cleaned upT-testType: test improvementscrate-zkevm-circuitsIssues related to the zkevm-circuits workspace membergood first issueGood for newcomers

Type

No type

Projects

Status

✅ Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions