Fix compatibility with wp-graphql-gutenberg-acf #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply casting the $attributes array to an object fails with ACF Pro's field groups, as there's another nested array. Using JSON decode makes sure that nested arrays are converted to objects as well There is also an issue with the HTML loader failing if there's no innerHTML defined in the block. HTML-less blocks are very useful for WordPress as a headless CMS with WPGraphQL.
pristas-peter
requested changes
Jul 18, 2021
| @@ -148,7 +148,13 @@ protected static function parse_attributes($data, $block_type) { | |||
|
|
|||
| $validator = new Validator(); | |||
|
|
|||
| $result = $validator->schemaValidation((object) $attributes, $schema); | |||
| if (empty($data['innerHTML'])) { | |||
| $data['innerHTML'] = '<span data-warning="This block does not contain a render template"></span>'; | |||
There was a problem hiding this comment.
Could we leave there just an empty span and log this message with error_log and E_WARNING ?
There was a problem hiding this comment.
Could do, but would need to conditionally call source_attributes with HtmlDomParser on L16, as that's what's causing the error. The DOM parser function error'so out when an empty string is passed in.
There was a problem hiding this comment.
I'd also say, having played around, I'm not entirely sure about what innerHTML is, in an ACF defined Gutenberg block, versus a WP core block. And whether it's supposed to contain the HTML from render Template, do you know?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply casting the
$attributesarray to an object before running it though Schema validationfails with ACF Pro's field groups. ACF outputs another nested array. Using JSON decode makes
sure that nested arrays are converted to objects as well.
There is also an issue with the HTML loader failing if there's no innerHTML defined in the block. HTML-less blocks are very useful for WordPress as a headless CMS with WPGraphQL.
I've added a check for empty HTML and added an empty span with a
data-attrwarning about the lack of innerHTML.