-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update toolchain and fix lint errors #5022
Conversation
aqrln
commented
Oct 17, 2024
•
edited
Loading
edited
- Update Nix flake
- Update Rust to 1.82.0
- Fix compiler warning for unused errors on Rust 1.81 (we keep those on purpose for documentation purposes)
- Fix deprecation warning on Rust 1.82
- Fix clippy warnings
- Update wasm-bindgen to match the version in Nix
- Update WASM toolchain to nightly-2024-09-01 (corresponds to Rust 1.82.0)
WASM Query Engine file Size
|
CodSpeed Performance ReportMerging #5022 will not alter performanceComparing Summary
|
We keep these around for documentation purposes.
db_schemas: &[&str], | ||
) -> ConnectorResult<InitResult> | ||
where | ||
EI: ExternalInitializer<'a> + ?Sized, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?Sized
bound was useless because ExternalInitializer<'_>
requires Sized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bundle size reduction in Wasm is a nice surprise!
Not really a surprise, this consistently happens every time we update the WASM toolchain. That's the compiler's job, to optimize code better, it should always be becoming ever faster and/or smaller, especially with LLVM updates. |
That's why we shouldn't be forgetting updating it 😉 |