Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update toolchain and fix lint errors #5022

Merged
merged 10 commits into from
Oct 18, 2024
Merged

chore: update toolchain and fix lint errors #5022

merged 10 commits into from
Oct 18, 2024

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Oct 17, 2024

  • Update Nix flake
  • Update Rust to 1.82.0
  • Fix compiler warning for unused errors on Rust 1.81 (we keep those on purpose for documentation purposes)
  • Fix deprecation warning on Rust 1.82
  • Fix clippy warnings
  • Update wasm-bindgen to match the version in Nix
  • Update WASM toolchain to nightly-2024-09-01 (corresponds to Rust 1.82.0)

@aqrln aqrln added this to the 5.22.0 milestone Oct 17, 2024
Copy link
Contributor

github-actions bot commented Oct 17, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.038MiB 2.063MiB -26.582KiB
Postgres (gzip) 819.666KiB 824.207KiB -4.542KiB
Mysql 2.004MiB 2.034MiB -31.083KiB
Mysql (gzip) 805.711KiB 812.031KiB -6.320KiB
Sqlite 1.902MiB 1.929MiB -27.699KiB
Sqlite (gzip) 765.805KiB 770.618KiB -4.813KiB

Copy link

codspeed-hq bot commented Oct 17, 2024

CodSpeed Performance Report

Merging #5022 will not alter performance

Comparing rust-1.81 (df2376a) with main (b9903dc)

Summary

✅ 11 untouched benchmarks

@aqrln aqrln marked this pull request as ready for review October 17, 2024 20:08
@aqrln aqrln requested a review from a team as a code owner October 17, 2024 20:08
@aqrln aqrln requested review from SevInf and removed request for a team October 17, 2024 20:08
db_schemas: &[&str],
) -> ConnectorResult<InitResult>
where
EI: ExternalInitializer<'a> + ?Sized,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?Sized bound was useless because ExternalInitializer<'_> requires Sized

Copy link
Contributor

@jkomyno jkomyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bundle size reduction in Wasm is a nice surprise!

@aqrln
Copy link
Member Author

aqrln commented Oct 18, 2024

The bundle size reduction in Wasm is a nice surprise!

Not really a surprise, this consistently happens every time we update the WASM toolchain. That's the compiler's job, to optimize code better, it should always be becoming ever faster and/or smaller, especially with LLVM updates.

@aqrln
Copy link
Member Author

aqrln commented Oct 18, 2024

That's why we shouldn't be forgetting updating it 😉

@aqrln aqrln merged commit 155af62 into main Oct 18, 2024
367 of 368 checks passed
@aqrln aqrln deleted the rust-1.81 branch October 18, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants