fix: remove actor system for transactions, refactor iTX and tracing #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqrln
changed the title
WASM Query Engine file Size
|
CodSpeed Performance ReportMerging #5001 will not alter performanceComparing Summary
|
|
I'm waiting for #5003 before being able to release a new integration version. |
aqrln
force-pushed
the
integration/itx-refactor
branch
4 times, most recently
from
21703fd
to
0014c6b
Compare
aqrln
force-pushed
the
integration/itx-refactor
branch
2 times, most recently
from
d9c03d9
to
ff4016d
Compare
aqrln
force-pushed
the
integration/itx-refactor
branch
from
ff4016d
to
17b7e56
Compare
It was never acquired for reading, only for writing, so it was useless. Mutex is much cheaper with less overhead. Perhaps the outer RwLock should be replaced with a Mutex as well, because, even though it is acquired for both reading and writing, it is held for a very short time by design so the overhead of RwLock is likely more expensive than the benefit of allowing multiple readers. RwLock is more useful when the lock is held for a long time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e1242e1 and re-applies #4940.
Integration: prisma/prisma#25285
Fixes: https://github.com/prisma/team-orm/issues/1270
Fixes: prisma/prisma#23792
Fixes: #4336
Fixes: prisma/prisma#21402
Fixes: prisma/prisma#20694
Closes: https://github.com/prisma/team-orm/issues/1285
/integration