Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(psl): handle named args in ds url env #4958

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Jul 18, 2024

Added new warning for named argument in datasource url env.
We now correctly propagate warnings from the ds url env

We now correctly propagate warnings from the ds url env
@Druue Druue added this to the 5.18.0 milestone Jul 18, 2024
@Druue Druue self-assigned this Jul 18, 2024
@Druue Druue requested a review from a team as a code owner July 18, 2024 01:14
@Druue Druue requested review from Weakky and removed request for a team July 18, 2024 01:14
Copy link

codspeed-hq bot commented Jul 18, 2024

CodSpeed Performance Report

Merging #4958 will not alter performance

Comparing fix/handle-env-named-args (8fc2a6d) with main (15f8fe4)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.056MiB 2.056MiB 351.000B
Postgres (gzip) 820.565KiB 820.390KiB 179.000B
Mysql 2.027MiB 2.026MiB 351.000B
Mysql (gzip) 808.380KiB 808.377KiB 3.000B
Sqlite 1.925MiB 1.925MiB 322.000B
Sqlite (gzip) 768.798KiB 768.535KiB 270.000B

@Druue Druue merged commit 77b82f6 into main Jul 19, 2024
223 checks passed
@Druue Druue deleted the fix/handle-env-named-args branch July 19, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants