Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fmt): add functionality from prisma-fmt as quick fixes #4945

Merged
merged 11 commits into from
Jul 15, 2024
Merged

feat(fmt): add functionality from prisma-fmt as quick fixes #4945

merged 11 commits into from
Jul 15, 2024

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Jul 9, 2024

@Druue Druue added this to the 5.17.0 milestone Jul 9, 2024
@Druue Druue requested a review from a team as a code owner July 9, 2024 12:13
@Druue Druue requested review from laplab and removed request for a team July 9, 2024 12:13
@Druue Druue marked this pull request as draft July 9, 2024 12:13
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4945 will not alter performance

Comparing feat/fmt-as-code-fixes (0c36c38) with main (d0037d0)

Summary

✅ 11 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.053MiB 2.053MiB 0.000B
Postgres (gzip) 820.249KiB 820.249KiB 0.000B
Mysql 2.022MiB 2.022MiB 0.000B
Mysql (gzip) 806.667KiB 806.668KiB -2.000B
Sqlite 1.922MiB 1.922MiB 0.000B
Sqlite (gzip) 768.553KiB 768.549KiB 4.000B

@Druue Druue marked this pull request as ready for review July 11, 2024 10:48
@Druue Druue changed the title feat(fmt): refactor functionality from prisma-fmt as quick fixes feat(fmt): add non-format functionality from prisma-fmt as quick fixes Jul 11, 2024
@Druue Druue changed the title feat(fmt): add non-format functionality from prisma-fmt as quick fixes feat(fmt): add functionality from prisma-fmt as quick fixes Jul 11, 2024
SevInf
SevInf approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@SevInf SevInf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions and questins, after that is addressed - lgtm

Druue and others added 2 commits July 15, 2024 10:16
@Druue @SevInf
Update prisma-fmt/src/code_actions/field.rs
b560fa1 
Co-authored-by: Serhii Tatarintsev <tatarintsev@prisma.io>
@Druue
rmv line, clippy
0c36c38
@Druue Druue merged commit 9721e9b into main Jul 15, 2024
207 checks passed
@Druue Druue deleted the feat/fmt-as-code-fixes branch July 15, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevInf SevInf SevInf approved these changes

@laplab laplab Awaiting requested review from laplab laplab is a code owner automatically assigned from prisma/orm-rust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Druue @SevInf