-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
query-engine-c-abi: Remove openssl dependency #4840
Conversation
WASM Query Engine file Size
|
✅ WASM query-engine performance won't change substantially (1.007x)Full benchmark report
After changes in 5ccaafd |
CodSpeed Performance ReportMerging #4840 will not alter performanceComparing Summary
|
Native drivers are not properly excluded in c-abi build: `quaint`'s `native` feature, pulled through `request-handlers` -> `sql-connector` chain pulls all drivers in. In turn, `tiberius` brings openssl requirement with it and that requires custom build for Android. This PR ensures that tiberus is properly excluded from quaint dependencies when building for native sqlite only. Unfortunately, that means that `native-*` features now propogate to `sql-query-connector` and `request-handlers` crates as well.
#[cfg(any( | ||
feature = "mssql-native", | ||
feature = "mysql-native", | ||
feature = "postgresql-native", | ||
feature = "sqlite-native" | ||
))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we alias it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aliases have to be set up per-crate and unless I am missing something this is a single usage of this combination in sql-query-connectror
, so not worth it, IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm painfully approving this.
Native drivers are not properly excluded in c-abi build:
quaint
'snative
feature, pulled throughrequest-handlers
->sql-connector
chain pulls all drivers in. In turn,
tiberius
brings opensslrequirement with it and that requires custom build for Android.
This PR ensures that tiberus is properly excluded from quaint
dependencies when building for native sqlite only. Unfortunately, that
means that
native-*
features now propogate tosql-query-connector
and
request-handlers
crates as well.Contributes to prisma/team-orm#1106