Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency typescript to v5.4.5 #4828

Merged
merged 1 commit into from
Apr 23, 2024
Merged

chore(deps): update dependency typescript to v5.4.5 #4828

merged 1 commit into from
Apr 23, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 13, 2024 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
typescript (source) 5.4.3 -> 5.4.5 age adoption passing confidence

Release Notes

Microsoft/TypeScript (typescript)

v5.4.5: TypeScript 5.4.5

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.4.4: TypeScript 5.4.4

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner April 13, 2024 02:14
@renovate renovate bot requested review from Weakky and removed request for a team April 13, 2024 02:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 13, 2024 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.129MiB 2.129MiB 0.000B
Postgres (gzip) 838.529KiB 838.530KiB -1.000B
Mysql 2.098MiB 2.098MiB 0.000B
Mysql (gzip) 825.355KiB 825.354KiB 1.000B
Sqlite 1.991MiB 1.991MiB 0.000B
Sqlite (gzip) 785.917KiB 785.917KiB 0.000B

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4828 will not alter performance

Comparing renovate/typescript-5.4.x (bd10f11) with main (3364458)

Summary

✅ 11 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 13, 2024 •
edited
Loading

✅ WASM query-engine performance won't change substantially (1.003x)

Full benchmark report 
DATABASE_URL="postgresql://postgres:postgres@localhost:5432/bench?schema=imdb_bench&sslmode=disable" \
node --experimental-wasm-modules query-engine/driver-adapters/executor/dist/bench.mjs
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
cpu: AMD EPYC 7763 64-Core Processor
runtime: node v18.20.2 (x64-linux)

benchmark                   time (avg)             (min … max)       p75       p99      p999
-------------------------------------------------------------- -----------------------------
• movies.findMany() (all - ~50K)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     286 ms/iter       (282 ms … 291 ms)    288 ms    291 ms    291 ms
Web Assembly: Latest       373 ms/iter       (371 ms … 375 ms)    375 ms    375 ms    375 ms
Web Assembly: Current      373 ms/iter       (371 ms … 378 ms)    377 ms    378 ms    378 ms
Node API: Current          197 ms/iter       (194 ms … 207 ms)    199 ms    207 ms    207 ms

summary for movies.findMany() (all - ~50K)
  Web Assembly: Current
   1.9x slower than Node API: Current
   1.31x slower than Web Assembly: Baseline
   1x faster than Web Assembly: Latest

• movies.findMany({ take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  11'659 µs/iter (11'253 µs … 16'590 µs) 11'434 µs 16'590 µs 16'590 µs
Web Assembly: Latest    15'430 µs/iter (15'141 µs … 16'611 µs) 15'428 µs 16'611 µs 16'611 µs
Web Assembly: Current   15'424 µs/iter (15'099 µs … 17'301 µs) 15'375 µs 17'301 µs 17'301 µs
Node API: Current        8'037 µs/iter   (7'845 µs … 8'515 µs)  8'085 µs  8'515 µs  8'515 µs

summary for movies.findMany({ take: 2000 })
  Web Assembly: Current
   1.92x slower than Node API: Current
   1.32x slower than Web Assembly: Baseline
   1x faster than Web Assembly: Latest

• movies.findMany({ where: {...}, take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   1'856 µs/iter   (1'750 µs … 3'108 µs)  1'833 µs  2'865 µs  3'108 µs
Web Assembly: Latest     2'427 µs/iter   (2'339 µs … 3'206 µs)  2'424 µs  3'067 µs  3'206 µs
Web Assembly: Current    2'412 µs/iter   (2'334 µs … 3'085 µs)  2'414 µs  2'850 µs  3'085 µs
Node API: Current        1'437 µs/iter   (1'301 µs … 2'791 µs)  1'415 µs  2'115 µs  2'791 µs

summary for movies.findMany({ where: {...}, take: 2000 })
  Web Assembly: Current
   1.68x slower than Node API: Current
   1.3x slower than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

• movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     546 ms/iter       (538 ms … 570 ms)    546 ms    570 ms    570 ms
Web Assembly: Latest       747 ms/iter       (743 ms … 757 ms)    749 ms    757 ms    757 ms
Web Assembly: Current      754 ms/iter       (746 ms … 771 ms)    758 ms    771 ms    771 ms
Node API: Current          472 ms/iter       (467 ms … 480 ms)    476 ms    480 ms    480 ms

summary for movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.6x slower than Node API: Current
   1.38x slower than Web Assembly: Baseline
   1.01x slower than Web Assembly: Latest

• movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  75'457 µs/iter (75'178 µs … 75'835 µs) 75'717 µs 75'835 µs 75'835 µs
Web Assembly: Latest       105 ms/iter       (105 ms … 106 ms)    105 ms    106 ms    106 ms
Web Assembly: Current      105 ms/iter       (105 ms … 106 ms)    106 ms    106 ms    106 ms
Node API: Current       61'577 µs/iter (60'471 µs … 63'158 µs) 62'807 µs 63'158 µs 63'158 µs

summary for movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.71x slower than Node API: Current
   1.4x slower than Web Assembly: Baseline
   1x faster than Web Assembly: Latest

• movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     973 ms/iter       (961 ms … 989 ms)    988 ms    989 ms    989 ms
Web Assembly: Latest     1'257 ms/iter   (1'249 ms … 1'282 ms)  1'262 ms  1'282 ms  1'282 ms
Web Assembly: Current    1'261 ms/iter   (1'249 ms … 1'288 ms)  1'284 ms  1'288 ms  1'288 ms
Node API: Current          872 ms/iter       (828 ms … 913 ms)    911 ms    913 ms    913 ms

summary for movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.45x slower than Node API: Current
   1.3x slower than Web Assembly: Baseline
   1x faster than Web Assembly: Latest

• movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     135 ms/iter       (135 ms … 136 ms)    136 ms    136 ms    136 ms
Web Assembly: Latest       174 ms/iter       (174 ms … 175 ms)    175 ms    175 ms    175 ms
Web Assembly: Current      174 ms/iter       (174 ms … 175 ms)    174 ms    175 ms    175 ms
Node API: Current          105 ms/iter       (104 ms … 106 ms)    106 ms    106 ms    106 ms

summary for movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.66x slower than Node API: Current
   1.29x slower than Web Assembly: Baseline
   1x faster than Web Assembly: Latest

• movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     865 µs/iter     (814 µs … 1'498 µs)    864 µs  1'356 µs  1'498 µs
Web Assembly: Latest     1'201 µs/iter   (1'138 µs … 1'766 µs)  1'208 µs  1'530 µs  1'766 µs
Web Assembly: Current    1'234 µs/iter   (1'147 µs … 2'016 µs)  1'219 µs  1'858 µs  2'016 µs
Node API: Current          785 µs/iter     (708 µs … 1'193 µs)    803 µs    938 µs  1'193 µs

summary for movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
  Web Assembly: Current
   1.57x slower than Node API: Current
   1.43x slower than Web Assembly: Baseline
   1.03x slower than Web Assembly: Latest

• movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     853 µs/iter     (813 µs … 1'503 µs)    855 µs  1'170 µs  1'503 µs
Web Assembly: Latest     1'203 µs/iter   (1'146 µs … 1'838 µs)  1'208 µs  1'560 µs  1'838 µs
Web Assembly: Current    1'203 µs/iter   (1'150 µs … 1'823 µs)  1'209 µs  1'551 µs  1'823 µs
Node API: Current          764 µs/iter     (711 µs … 1'116 µs)    796 µs    936 µs  1'116 µs

summary for movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
  Web Assembly: Current
   1.57x slower than Node API: Current
   1.41x slower than Web Assembly: Baseline
   1x faster than Web Assembly: Latest

After changes in bd10f11

@renovate renovate bot force-pushed the renovate/typescript-5.4.x branch from db34116 to bd10f11 Compare April 20, 2024 01:20
@renovate renovate bot changed the title chore(deps): update dependency typescript to v5.4.4 chore(deps): update dependency typescript to v5.4.5 Apr 20, 2024
@Jolg42 Jolg42 added this to the 5.13.0 milestone Apr 23, 2024
@Jolg42 Jolg42 merged commit e5f3dd7 into main Apr 23, 2024
181 checks passed
@Jolg42 Jolg42 deleted the renovate/typescript-5.4.x branch April 23, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

@Weakky Weakky Awaiting requested review from Weakky Weakky is a code owner automatically assigned from prisma/orm-rust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.13.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Jolg42