Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy errors and warnings with Rust 1.72 #4169

Merged
merged 13 commits into from
Aug 25, 2023
Merged

Fix clippy errors and warnings with Rust 1.72 #4169

merged 13 commits into from
Aug 25, 2023

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Aug 25, 2023

Fix clippy errors and warnings.

Next PR to update Rust in Nix flake: #4170

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 25, 2023

CodSpeed Performance Report

Merging #4169 will improve performances by 5.06%

Comparing rust-1.72 (65e5ca7) with main (9f8ddf5)

Summary

🔥 1 improvements
✅ 10 untouched benchmarks

Benchmarks breakdown

Benchmark main rust-1.72 Change
🔥 large_read 7.7 ms 7.3 ms +5.06%

@aqrln aqrln force-pushed the rust-1.72 branch 3 times, most recently from 51dadf0 to 72b556c Compare August 25, 2023 14:48
@aqrln aqrln marked this pull request as ready for review August 25, 2023 14:49
@aqrln aqrln requested a review from a team as a code owner August 25, 2023 14:49
@aqrln aqrln changed the title Update to Rust 1.72 and fix clippy errors Fix clippy errors and warnings with Rust 1.72 Aug 25, 2023
@aqrln aqrln merged commit f957933 into main Aug 25, 2023
60 checks passed
@aqrln aqrln deleted the rust-1.72 branch August 25, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants