Skip to content

Commit

Permalink
we no longer return early, no need for the comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Druue committed Jul 8, 2024
1 parent 39876e4 commit fc8531c
Showing 1 changed file with 0 additions and 26 deletions.
26 changes: 0 additions & 26 deletions psl/parser-database/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -107,35 +107,9 @@ impl ParserDatabase {
// First pass: resolve names.
names::resolve_names(&mut ctx);

// Return early on name resolution errors.
// if ctx.diagnostics.has_errors() {
// attributes::create_default_attributes(&mut ctx);

// return ParserDatabase {
// asts,
// interner,
// names,
// types,
// relations,
// };
// }

// Second pass: resolve top-level items and field types.
types::resolve_types(&mut ctx);

// Return early on type resolution errors.
// if ctx.diagnostics.has_errors() {
// attributes::create_default_attributes(&mut ctx);

// return ParserDatabase {
// asts,
// interner,
// names,
// types,
// relations,
// };
// }

// Third pass: validate model and field attributes. All these
// validations should be _order independent_ and only rely on
// information from previous steps, not from other attributes.
Expand Down

0 comments on commit fc8531c

Please sign in to comment.