Repository navigation
feat: stable types node and exit hooks - #18899
Conversation
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview: 🚮 Removed packages: @types/node@12.20.55, @types/node@14.14.21 |
CodSpeed Performance ReportMerging #18899 Summary
|
|
For me this fixes an issue which currently prevents me from deploying to Northflank using If I build the app on a local machine I don't get this error. This should relate to the breaking changes in this Node pull request. Should I still open an issue for this? |
| // the usual way to exit with a signal is to add 128 to the signal number | ||
| const exitCode = os.constants.signals[signal] + 128 |
There was a problem hiding this comment.
People might rely on the old exitCode, not sure if we want to do this change in a standard release?
There was a problem hiding this comment.
Considering this is a direct consequence of Node.js changing its behavior, that's not up to us.
Afaik, as long as we don't turn a 0 exit code into another number, everything's fine
There was a problem hiding this comment.
I am with Alberto on this, right now, you applications exit code changes to 0 if you set our beforeExit hook, this change would restore them to what they are by default.
There was a problem hiding this comment.
Not sure about this since it was always 0 until this PR.
Also, we would at least need a test for this? It's an important bit that is still untested based on the CI run here?
There was a problem hiding this comment.
It was not always 0. We set our signal handlers only when you add beforeExit event listener. If you don't do it, exit code will be default one, 128 + signal.
There was a problem hiding this comment.
Which means it was always 0 for people using the beforeExit event listener 😄
|
Sigh, tests are failing due to unrelated snapshot changes |
40cfeaa to
a281efa
Compare
See Slack thread.
Fixes #17127.
This PR:
@types/nodefor the public Prisma packages to v14.18.42.@types/nodeversions