-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vsc): Add PDP notification #1716
Conversation
🤖 Pull request artifactsempty string
|
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
Note: I'll review this today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some detail changes for text and link required, but functionality should stay unchanged.
This looks good (but waiting for some last updates on some text). |
I just found out this in VS Code docs though 😅 https://code.visualstudio.com/api/ux-guidelines/notifications
❌ Don't
|
As that is our default behavior, to only show the notification once, I think our implementation already follows the spirit of what this is intended to achieve - and an additional button might not be necessary. Agree? |
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
FYI it seems that some people are unhappy about this: https://twitter.com/StefanTMD/status/1790827370032578775 |
It is very low and devious to use notifications to display ads and promotions. |
We heard your feedback, here is the PR that will remove the promotion for next release: #1745 |
closes https://github.com/prisma/team-orm/issues/1132