Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vsc): Add PDP notification #1716

Merged
merged 10 commits into from
May 13, 2024
Merged

feat(vsc): Add PDP notification #1716

merged 10 commits into from
May 13, 2024

Conversation

Druue
Copy link
Contributor

@Druue Druue commented May 7, 2024

@Druue Druue added this to the 5.14.0 milestone May 7, 2024
@Druue Druue requested review from janpio and Jolg42 May 7, 2024 13:10
Copy link

github-actions bot commented May 7, 2024

🤖 Pull request artifacts

empty string

file commit
prisma.vsix e84ac82

github-actions bot added a commit that referenced this pull request May 7, 2024
Copy link

github-actions bot commented May 7, 2024

github-actions bot added a commit that referenced this pull request May 7, 2024
github-actions bot added a commit that referenced this pull request May 7, 2024
github-actions bot added a commit that referenced this pull request May 7, 2024
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
github-actions bot added a commit that referenced this pull request May 7, 2024
packages/vscode/package.json Outdated Show resolved Hide resolved
github-actions bot added a commit that referenced this pull request May 7, 2024
@Jolg42
Copy link
Contributor

Jolg42 commented May 8, 2024

Note: I'll review this today

Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some detail changes for text and link required, but functionality should stay unchanged.

@Jolg42
Copy link
Contributor

Jolg42 commented May 8, 2024

This looks good (but waiting for some last updates on some text).
The behavior from what I see is that it will show up only once when the Prisma extension gets activated. (No matter if clicked or dismissed by the user).

packages/vscode/package.json Outdated Show resolved Hide resolved
@Jolg42
Copy link
Contributor

Jolg42 commented May 8, 2024

I just found out this in VS Code docs though 😅
Based on that promotion is not recommended, and adding a Do not show again button is recommended, I find this part interesting because as a user if I don't want to click "Visit" it gives a clear option for dismissing it which tells me that it won't show up again.

https://code.visualstudio.com/api/ux-guidelines/notifications
✔️ Do

Respect the user's attention by only sending notifications when absolutely necessary
Add a Do not show again option for every notification
Show one notification at a time

❌ Don't

Send repeated notifications
Use for promotion
Ask for feedback on the first install
Show actions if there aren't any

packages/vscode/package.json Outdated Show resolved Hide resolved
@janpio
Copy link
Contributor

janpio commented May 8, 2024

Add a Do not show again option for every notification

As that is our default behavior, to only show the notification once, I think our implementation already follows the spirit of what this is intended to achieve - and an additional button might not be necessary. Agree?

Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 8, 2024
github-actions bot added a commit that referenced this pull request May 8, 2024
github-actions bot added a commit that referenced this pull request May 8, 2024
packages/vscode/package.json Outdated Show resolved Hide resolved
github-actions bot added a commit that referenced this pull request May 10, 2024
@janpio janpio merged commit 48e0775 into main May 13, 2024
7 checks passed
@janpio janpio deleted the feat/pdp-promo-notif branch May 13, 2024 11:33
@Haroenv
Copy link

Haroenv commented May 16, 2024

FYI it seems that some people are unhappy about this: https://twitter.com/StefanTMD/status/1790827370032578775

@madsoulswe
Copy link

madsoulswe commented May 16, 2024

It is very low and devious to use notifications to display ads and promotions.
This will only hurt your brand and VS Code

@janpio
Copy link
Contributor

janpio commented May 28, 2024

We heard your feedback, here is the PR that will remove the promotion for next release: #1745

Druue added a commit that referenced this pull request May 28, 2024
* Revert "feat(vsc): Add PDP notification (#1716)"

This reverts commit 48e0775.

---------

Co-authored-by: Sophie <29753584+Druue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants