Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error shifting due to Cyrillic characters encoding issue #1726

Closed
kyrtion opened this issue May 15, 2024 · 1 comment
Closed

Syntax error shifting due to Cyrillic characters encoding issue #1726

kyrtion opened this issue May 15, 2024 · 1 comment
Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. topic: validation

Comments

@kyrtion
Copy link

kyrtion commented May 15, 2024

The issue with Cyrillic characters is that when the VSCode extension takes the character value and counts by bytes, if there are Cyrillic characters, it will be 2 bytes, and each byte contains a position. This means that if I enter Cyrillic characters, the syntax error will shift by +1 character.

Sample cyrillic text:

Привет
Как дела
Здравствуйте
Чем занимаетесь?
Я там побывал место, мне понравился путешествие

image
image

  • OS: Windows 10 Pro
  • Editor: VS Code
  • Editor version: 1.89.1 (user setup)
  • Extension version: 5.14.0
@janpio janpio added bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. kind/bug A reported bug. labels May 15, 2024
@Jolg42 Jolg42 added domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. topic: syntax highlighting labels May 23, 2024
@Druue Druue added bug/2-confirmed Bug has been reproduced and confirmed. topic: validation and removed bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. topic: syntax highlighting labels Jun 12, 2024
@Druue
Copy link
Contributor

Druue commented Jun 12, 2024

Hey! thank you for the report; we are already aware of this issue where multibyte characters shift our validations. I will be closing this as a duplicate of #1308

@Druue Druue closed this as completed Jun 12, 2024
@janpio janpio closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. topic: validation
Projects
None yet
Development

No branches or pull requests

4 participants