Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Heroku deployment guide #624

Merged
merged 4 commits into from
Jul 9, 2020
Merged

Add Heroku deployment guide #624

merged 4 commits into from
Jul 9, 2020

Conversation

2color
Copy link
Contributor

@2color 2color commented Jul 7, 2020 •
edited
Loading

Related issue: #616

@mhwelander mhwelander mentioned this pull request Jul 7, 2020
Closed
janpio
janpio approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Just to confirm: Nothing is special to be able to deploy on Heroku, right?

@2color
Copy link
Contributor Author

2color commented Jul 8, 2020

Just to confirm: Nothing is special to be able to deploy on Heroku, right?

Just setting your application to bind to the env var PORT which the Heroku runtime sets.

nikolasburk
nikolasburk requested changes Jul 8, 2020
View reviewed changes
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Daniel! I've left a few minor comments but then it' ready to merge I think 🚀

content/04-guides/02-deployment/00-deploying-to-heroku.md Show resolved Hide resolved
content/04-guides/02-deployment/00-deploying-to-heroku.md Outdated Show resolved Hide resolved
content/04-guides/02-deployment/00-deploying-to-heroku.md Outdated Show resolved Hide resolved
content/04-guides/02-deployment/00-deploying-to-heroku.md Outdated Show resolved Hide resolved
content/04-guides/02-deployment/00-deploying-to-heroku.md Outdated Show resolved Hide resolved
@2color 2color requested a review from nikolasburk July 8, 2020 11:37
@2color
Copy link
Contributor Author

2color commented Jul 8, 2020

Addressed Niko's comments and also added a Heroku specific notes section

@2color 2color merged commit a97b187 into master Jul 9, 2020
@2color 2color deleted the add-heroku-guide branch July 9, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio approved these changes

@mhwelander mhwelander Awaiting requested review from mhwelander

@ryands17 ryands17 Awaiting requested review from ryands17

@nikolasburk nikolasburk Awaiting requested review from nikolasburk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2color @janpio @nikolasburk