Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create another support article #1175

Merged
merged 9 commits into from
Jan 15, 2021
Merged

create another support article #1175

merged 9 commits into from
Jan 15, 2021

Conversation

ryands17
Copy link
Contributor

No description provided.

@ryands17 ryands17 requested a review from nikolasburk January 14, 2021 09:56
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks a lot Ryan! I've made a few suggestions, mostly with respect to style and formatting but also minor content adjustments:

  • I noticed that you provided a solution for a problem that wasn't outlined in the problem section, so I added this to the problem section as well
  • In docs, we should never use "I" or "me" (this might be ok in blog posts that have a clear author so people know who the person is that's writing I or me, but in docs we should remain neutral and only talk to the reader directly, see the style guide here)
  • I made sure consistent formatting is used

ryands17 and others added 7 commits January 14, 2021 15:56
…ed-on-relation.mdx

Co-authored-by: Nikolas <nikolas.burk@gmail.com>
…ed-on-relation.mdx

Co-authored-by: Nikolas <nikolas.burk@gmail.com>
…ed-on-relation.mdx

Co-authored-by: Nikolas <nikolas.burk@gmail.com>
…ed-on-relation.mdx

Co-authored-by: Nikolas <nikolas.burk@gmail.com>
…ed-on-relation.mdx

Co-authored-by: Nikolas <nikolas.burk@gmail.com>
…ed-on-relation.mdx

Co-authored-by: Nikolas <nikolas.burk@gmail.com>
…ed-on-relation.mdx

Co-authored-by: Nikolas <nikolas.burk@gmail.com>
@nikolasburk nikolasburk merged commit 423a2b9 into master Jan 15, 2021
@nikolasburk nikolasburk deleted the relation-querying branch January 15, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants