Symfony 6 and PHP 8.1+ #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turn types everywhere possible, fix/optimize legacy code blocks
d-ph
reviewed
Mar 16, 2023
d-ph
reviewed
Mar 16, 2023
d-ph
reviewed
Mar 16, 2023
d-ph
reviewed
Mar 16, 2023
d-ph
reviewed
Mar 16, 2023
…ix deprecated database platform check.
d-ph
reviewed
Mar 17, 2023
d-ph
reviewed
Mar 17, 2023
|
Status: This PR looks good to me at this point. Awaiting for the other related projects, as discussed elsewhere. |
sudoash
reviewed
Mar 30, 2023
| @@ -75,7 +69,8 @@ public function execute(InputInterface $input, OutputInterface $output) | |||
| */ | |||
| if (!in_array('queue_task', $dbal->getSchemaManager()->listTableNames())) { | |||
| $output->writeln("<error>Couldn't find the queue tasks table in the database. This is expected, if the bundle is used for the first time. Otherwise it's a critical error you should investigate.</error>"); | |||
| return; | |||
|
|
|||
| return static::FAILURE; | |||
There was a problem hiding this comment.
This needs changing to return static::SUCCESS or will potentially fail builds. This is not strictly a failure as the output message suggests, so will also need to change <error> to <comment>.
…he queue tasks table in the database." as SUCCESS to prevent build fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for Symfony 6+ and drops support for previous versions