Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy all contracts with create2 #59

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Deploy all contracts with create2 #59

merged 2 commits into from
Dec 20, 2023

Conversation

shaspitz
Copy link
Contributor

@shaspitz shaspitz commented Dec 17, 2023 •
edited
Loading

  • Deploys all contracts with create2 proxy
  • Updates some docs

Note _transferOwnership is necessary to make sure contract owner becomes the deployment tx originator, not the proxy contract. See OpenZeppelin/openzeppelin-contracts#2639 for more details

@shaspitz shaspitz requested a review from ckartik December 17, 2023 03:11
ckartik
ckartik approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@ckartik ckartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question otherwise looks good!

@shaspitz shaspitz force-pushed the deploy-all-with-create2 branch from a9520c3 to 530b4d1 Compare December 20, 2023 11:00
@shaspitz shaspitz merged commit d631537 into main Dec 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckartik ckartik ckartik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaspitz @ckartik