[ActionList] If role='listbox' is used on an ActionList default items to role='option' - #2925
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c629332 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
kendallgassner
force-pushed
the
kendallg/change-aria-for-option
branch
from
June 27, 2024 20:51
95ee21d to
3b34ed6
Compare
kendallgassner
force-pushed
the
kendallg/change-aria-for-option
branch
from
June 27, 2024 21:12
be7b31b to
64581f3
Compare
kendallgassner
force-pushed
the
kendallg/change-aria-for-option
branch
from
June 27, 2024 21:36
56dcdef to
51b170d
Compare
kendallgassner
force-pushed
the
kendallg/change-aria-for-option
branch
from
June 27, 2024 21:50
c00ff60 to
140f3d9
Compare
kendallgassner
force-pushed
the
kendallg/change-aria-for-option
branch
from
June 27, 2024 22:52
2ea7439 to
0de9e02
Compare
kendallgassner
force-pushed
the
kendallg/change-aria-for-option
branch
from
June 27, 2024 22:58
cdbe179 to
0a3e729
Compare
jonrohan
approved these changes
Jun 27, 2024
Co-authored-by: Jon Rohan <rohan@github.com>
Co-authored-by: Jon Rohan <rohan@github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
if
role='option'is passed in change the default role of the ActionList items torole='option'Screenshots
Integration
List the issues that this change affects.
Closes # (type the GitHub issue number after #)
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.