Skip to content

Add support for target on links inside Breadcrumbs - #2887

Merged
camertron merged 1 commit into
primer:mainfrom
opf:feat/add-support-for-target-attribute
Jun 7, 2024
Merged

Add support for target on links inside Breadcrumbs#2887
camertron merged 1 commit into
primer:mainfrom
opf:feat/add-support-for-target-attribute

Conversation

@HDinger

@HDinger HDinger commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

What are you trying to accomplish?

This adds the support for target attributes on the links of a Primer::Beta::Breadcrumbs.

List the issues that this change affects.

Closes #2886

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@HDinger
HDinger requested a review from a team as a code owner June 7, 2024 10:46
@HDinger
HDinger requested a review from camertron June 7, 2024 10:46
@changeset-bot

changeset-bot Bot commented Jun 7, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3ccb6b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breadcrumb links can't control the target attribute

2 participants