Skip to content

fix: Fix NVDA menu item counts that are broken by <form> #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camertron merged 3 commits into from
May 8, 2024
Merged

fix: Fix NVDA menu item counts that are broken by <form> #2822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abc6f65
fix: Suppress form semantics so menu semantics take precedence
smockle May 3, 2024
60c8416
chore: Add changeset
smockle May 3, 2024
418b6cc
fix: Only suppress form semantics in ActionMenu (i.e. not ActionList)
smockle May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gorgeous-turtles-agree.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/view-components": patch
---

Fix NVDA menu item counts that are broken by using '<form>' inside an 'ActionMenu'.
8 changes: 7 additions & 1 deletion app/components/primer/alpha/action_menu/list.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,12 @@ def add_item(item, to:)
def organize_arguments(data: {}, **system_arguments)
content_arguments = system_arguments.delete(:content_arguments) || {}

# When a form is inside a menu, suppress form semantics.
# Otherwise, NVDA will miscount menu items.
form_arguments = system_arguments.delete(:form_arguments) || {}
form_arguments[:html] = form_arguments[:html] || {}
form_arguments[:html][:role] = :none

if system_arguments[:tag] && ITEM_TAG_OPTIONS.include?(system_arguments[:tag])
content_arguments[:tag] = system_arguments[:tag]
end
Expand All @@ -115,7 +121,7 @@ def organize_arguments(data: {}, **system_arguments)
)
end

{ data: data, **system_arguments, content_arguments: content_arguments }
{ data: data, **system_arguments, content_arguments: content_arguments, form_arguments: form_arguments }
end
end
end
Expand Down