Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible scheme for danger buttons is missing #2969

Closed
HDinger opened this issue Jul 26, 2024 · 4 comments
Closed

Invisible scheme for danger buttons is missing #2969

HDinger opened this issue Jul 26, 2024 · 4 comments
Labels

Comments

@HDinger
Copy link
Contributor

HDinger commented Jul 26, 2024

Pain point

  • We often use invisble schemes of buttons to avoid a cognitive overload in an area where multiple buttons are shown next to each other.
  • The danger scheme of buttons is a great thing to hint users of a potentially dangerous action. This effect is achieved by a red font and the strong hover effect. However, there is no invisible scheme for the danger buttons which breaks the design heavily.
  • As the danger effect is only achieved via font and on hover, it could be possible to create an invisible_danger scheme (although I have to admit that the name might be confusing).

Example screenshot

With icon buttons
Bildschirmfoto 2024-07-26 um 08 15 02

I know that this is basically a deisgn decision, so I'd be interested in your opinions on this. I'd also be happy to create a PR for such a scheme if you agree with that approach.

@camertron
Copy link
Contributor

Thanks for bringing this up! Imma let Primer Design weigh in on this 😄

@tallys
Copy link

tallys commented Aug 6, 2024

We'll bring this up at an upcoming Primer Patterns, there might be some issues around the accessibility — we generally do not use color to indicate meaning on icons.

cc @mperrotti can you add this to the agenda?

@mperrotti
Copy link
Contributor

We discussed this in today's Primer Patterns working session and we don't actually think this button needs to be a "danger" variant. For destructive or irremediable actions, we typically show a confirmation dialog for extra friction.

TL;DR - just use the "invisible" variant and show a confirmation dialog if it's actually a destructive action.

@lesliecdubs
Copy link
Member

👋 I'm going to go ahead and close this issue as per the recommendation in the last comment: #2969 (comment). Please feel free to respond for clarification, or reopen the issue if there's more you'd like to discuss. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants