-
Notifications
You must be signed in to change notification settings - Fork 646
chore(FormControl): remove sx props #6295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 1642708 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes inline style props from the FormControl component in favor of CSS class-based styling. The change aims to consolidate styling approaches by removing the display, flexDirection, and alignItems props from the Box component and relying on the classes.ControlVerticalLayout CSS class instead.
- Removes three inline style props (
display,flexDirection,alignItems) from the FormControl Box component - Maintains styling through the existing
classes.ControlVerticalLayoutCSS class
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/389123 |
|
🟢 golden-jobs completed with status |
These styles are already in css modules in the applied class https://github.com/primer/react/blob/main/packages/react/src/FormControl/FormControl.module.css#L10-L12
Changelog
Removed
Rollout strategy
Testing & Reviewing
Merge checklist