Skip to content

Conversation

@francinelucca
Copy link
Member

@francinelucca francinelucca commented Jul 7, 2025

These styles are already in css modules in the applied class https://github.com/primer/react/blob/main/packages/react/src/FormControl/FormControl.module.css#L10-L12

Changelog

Removed

  • SX props from FormControl

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copilot AI review requested due to automatic review settings July 7, 2025 20:10
@francinelucca francinelucca requested a review from a team as a code owner July 7, 2025 20:10
@francinelucca francinelucca requested a review from TylerJDev July 7, 2025 20:10
@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2025

🦋 Changeset detected

Latest commit: 1642708

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes inline style props from the FormControl component in favor of CSS class-based styling. The change aims to consolidate styling approaches by removing the display, flexDirection, and alignItems props from the Box component and relying on the classes.ControlVerticalLayout CSS class instead.

  • Removes three inline style props (display, flexDirection, alignItems) from the FormControl Box component
  • Maintains styling through the existing classes.ControlVerticalLayout CSS class

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.37 KB (-0.06% 🔽)
packages/react/dist/browser.umd.js 92.49 KB (-0.09% 🔽)

@github-actions github-actions bot requested a deployment to storybook-preview-6295 July 7, 2025 20:15 Abandoned
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/389123

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 7, 2025
@francinelucca francinelucca added this pull request to the merge queue Jul 7, 2025
Merged via the queue into main with commit 12468d8 Jul 7, 2025
43 checks passed
@francinelucca francinelucca deleted the fix/remove-sx-props branch July 7, 2025 20:49
@primer primer bot mentioned this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants