Skip to content

Fix Button styles while dragging inactive variants #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liuliu-dev merged 4 commits into from
Jul 10, 2025
Merged

Fix Button styles while dragging inactive variants #6277

liuliu-dev merged 4 commits into from
Jul 10, 2025

Conversation

@liuliu-dev
Copy link
Contributor

@liuliu-dev liuliu-dev commented Jul 2, 2025 •
edited
Loading

Closes #5375

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copilot AI review requested due to automatic review settings July 2, 2025 23:34
@liuliu-dev liuliu-dev requested a review from a team as a code owner July 2, 2025 23:34
@liuliu-dev liuliu-dev requested a review from TylerJDev July 2, 2025 23:34
@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 7fd68eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI reviewed Jul 2, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • packages/react/src/Button/ButtonBase.module.css: Language not supported

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.01 KB (0%)
packages/react/dist/browser.umd.js 92.29 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-6277 July 2, 2025 23:45 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6277 July 2, 2025 23:59 Inactive
@liuliu-dev liuliu-dev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 3, 2025
@primer primer bot requested a review from a team as a code owner July 3, 2025 00:14
@primer primer bot requested a review from mperrotti July 3, 2025 00:14
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 3, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6277 July 3, 2025 00:28 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6277 July 3, 2025 21:29 Inactive
@liuliu-dev liuliu-dev force-pushed the liuliu/fix-button-inactive-drag-styles branch 2 times, most recently from 4b527c2 to 5a7a1b6 Compare July 7, 2025 18:22
@github-actions github-actions bot temporarily deployed to storybook-preview-6277 July 7, 2025 18:25 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6277 July 7, 2025 18:35 Inactive
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 7, 2025
TylerJDev
TylerJDev approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@TylerJDev TylerJDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liuliu-dev liuliu-dev enabled auto-merge July 8, 2025 16:09
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@liuliu-dev liuliu-dev added this pull request to the merge queue Jul 10, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6277 July 10, 2025 00:55 Inactive
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 10, 2025
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 10, 2025
@primer-integration
Copy link

primer-integration bot commented Jul 10, 2025

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/390046

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Jul 10, 2025
@primer-integration
Copy link

primer-integration bot commented Jul 10, 2025

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jul 10, 2025
@liuliu-dev liuliu-dev added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit b384225 Jul 10, 2025
43 checks passed
@liuliu-dev liuliu-dev deleted the liuliu/fix-button-inactive-drag-styles branch July 10, 2025 18:56
@primer primer bot mentioned this pull request Jul 10, 2025
Merged
llastflowers pushed a commit that referenced this pull request Jul 23, 2025
@liuliu-dev @primer @llastflowers
Fix Button styles while dragging inactive variants (#6277)
aa77013 
Co-authored-by: primer[bot] <119360173+primer[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@TylerJDev TylerJDev TylerJDev approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti was automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liuliu-dev @TylerJDev