Skip to content

Add CSS variable to contrast TextInput #6270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
langermank merged 2 commits into from
Jul 2, 2025
Merged

Add CSS variable to contrast TextInput #6270

langermank merged 2 commits into from
Jul 2, 2025

Conversation

@langermank
Copy link
Contributor

@langermank langermank commented Jul 2, 2025

This adds a new CSS variable that we're adding behind a feature flag in gh/gh to test a color change to the contrast prop in order to eventually deprecate it.

Copilot AI review requested due to automatic review settings July 2, 2025 16:07
@langermank langermank requested a review from a team as a code owner July 2, 2025 16:07
@langermank langermank requested a review from jonrohan July 2, 2025 16:07
@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2025

⚠️ No Changeset found

Latest commit: ec7d316

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 2, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-6270 July 2, 2025 16:11 Abandoned
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.47 KB (0%)
packages/react/dist/browser.umd.js 92.46 KB (0%)

Copilot AI reviewed Jul 2, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@langermank langermank added this pull request to the merge queue Jul 2, 2025
Merged via the queue into main with commit b2a44c3 Jul 2, 2025
35 checks passed
@langermank langermank deleted the add-input-var branch July 2, 2025 16:43
@primer primer bot mentioned this pull request Jul 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jonrohan jonrohan jonrohan approved these changes

@lukasoppermann lukasoppermann lukasoppermann approved these changes

Assignees

No one assigned

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@langermank @jonrohan @lukasoppermann