-
Notifications
You must be signed in to change notification settings - Fork 646
Add className, width and height props to ConfirmationDialog #6107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: a60db38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the ConfirmationDialog component by allowing users to pass custom CSS classes and control its dimensions. Key updates include:
- Introducing
className,width, andheightprops (withwidthdefaulting to"medium") in both the interface and component implementation - Forwarding these props to the underlying
<Dialog> - Adding tests to confirm the new props function as expected
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react/src/ConfirmationDialog/ConfirmationDialog.tsx | Added className, width, and height to props interface; forwarded them to <Dialog> with width="medium" as default |
| packages/react/src/ConfirmationDialog/ConfirmationDialog.test.tsx | Introduced tests for className, width, and height props |
Comments suppressed due to low confidence (1)
packages/react/src/ConfirmationDialog/ConfirmationDialog.tsx:113
- Add a test to verify that
ConfirmationDialogdefaults itswidthto"medium"when nowidthprop is provided, ensuring backward compatibility is maintained.
width = 'medium',
size-limit report 📦
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
francinelucca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/379405 |
|
🟢 golden-jobs completed with status |
Summary
This PR adds support for
className,width, andheightprops to theConfirmationDialogcomponent, allowing users to customize the component's styling and dimensions.Changes
className,width, andheightprops to theConfirmationDialogPropsinterfaceConfirmationDialogcomponent to pass these props to the underlyingDialogcomponentwidth="medium"as default to maintain backward compatibilityExample
Fixes #6106.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.