Skip to content

Conversation

@francinelucca
Copy link
Member

@francinelucca francinelucca commented May 9, 2025

Changelog

New

  • Added maxWidth and maxHeight prop to responsive fullscreen variant CSS in overlay to override previous set values

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copilot AI review requested due to automatic review settings May 9, 2025 21:36
@francinelucca francinelucca requested a review from a team as a code owner May 9, 2025 21:36
@francinelucca francinelucca requested a review from jonrohan May 9, 2025 21:36
@changeset-bot
Copy link

changeset-bot bot commented May 9, 2025

🦋 Changeset detected

Latest commit: 1aabee5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that the fullscreen variant of the Overlay resets any previously applied max-width and max-height constraints, allowing it to truly occupy the full viewport.

  • Added max-width: 100vw to override prior width limits in fullscreen mode
  • Added max-height: unset to remove prior height limits in fullscreen mode

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96 KB (0%)
packages/react/dist/browser.umd.js 96.2 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-6036 May 9, 2025 21:45 Abandoned
francinelucca and others added 2 commits May 9, 2025 17:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to storybook-preview-6036 May 9, 2025 21:58 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-6036 May 12, 2025 15:49 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6036 May 12, 2025 16:03 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-6036 May 12, 2025 17:41 Abandoned
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/377497

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels May 12, 2025
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@francinelucca francinelucca added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit 21a3529 May 14, 2025
35 checks passed
@francinelucca francinelucca deleted the fix/full-screen-overlay-reset-max-values branch May 14, 2025 15:33
@primer primer bot mentioned this pull request May 14, 2025
hectahertz pushed a commit that referenced this pull request May 20, 2025
…6036)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants