added default button type to switch button to prevent submit when included in form #5841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 54b392d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
This PR implements the change for the ToggleSwitch default behavior to act as a button rather than a submit button. I haven't added the full test suite yet, and I'm looking for guidance on what tests would be most valuable for this change. I'm eager to iterate based on your feedback. |
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/react into dwsosa/defaultTypeForSwitchButton
jonrohan
approved these changes
Apr 17, 2025
hectahertz
pushed a commit
that referenced
this pull request
May 20, 2025
…luded in form (#5841) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jon Rohan <yes@jonrohan.codes>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5823
Added a variable to the switch button interface and added a default value of "button" so that the toggleswitch component doesnt default to "submit" which is an issue when the toggleswitch is added to a form
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist
Jest test result to confirm the type attribute has value "button"
