Skip to content

FIx UnderlineNav docs formatting causing MDX parser to fail #5774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

mperrotti
Copy link
Contributor

When trying to render this as Markdown, the parser gives an error because it thinks we literally wanted to render an anchor tag, not the string '<a>'. Using backticks instead of single quotes should fix this.

Expected a closing tag for `<a>` (1:73-1:76) before the end of `paragraph`

> 1 | The URL that the item navigates to. 'href' is passed to the underlying '<a>' element. If 'as' is specified, the component may need different props and 'href' is ignored. (Required prop for the react router is 'to' for example)

@mperrotti mperrotti requested a review from a team as a code owner March 14, 2025 17:07
@mperrotti mperrotti requested a review from joshblack March 14, 2025 17:07
Copy link

changeset-bot bot commented Mar 14, 2025

⚠️ No Changeset found

Latest commit: 5feb2a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mperrotti mperrotti added the skip changeset This change does not need a changelog label Mar 14, 2025
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 106.06 KB (0%)
packages/react/dist/browser.umd.js 106.41 KB (0%)

@mperrotti mperrotti changed the title FIx UnderlinePanels docs formatting causing MDX parser to fail FIx UnderlineNav docs formatting causing MDX parser to fail Mar 14, 2025
@mperrotti mperrotti added this pull request to the merge queue Mar 14, 2025
Merged via the queue into main with commit 402bc75 Mar 14, 2025
51 of 52 checks passed
@mperrotti mperrotti deleted the mp/underlinepanels-docs-formatting branch March 14, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants