Skip to content

Add -- prefix to CSS Custom Property for SkeletonBox #5768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2025
Merged

Add -- prefix to CSS Custom Property for SkeletonBox #5768

merged 2 commits into from
Mar 13, 2025

Conversation

joshblack
Copy link
Member

Update the CSS Custom Property to be properly formatted.

Changelog

New

Changed

  • Update base-duration to --base-duration

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

@joshblack joshblack requested a review from a team as a code owner March 13, 2025 14:58
@joshblack joshblack requested a review from jonrohan March 13, 2025 14:58
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 1e0a65a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 13, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 106.05 KB (0%)
packages/react/dist/browser.umd.js 106.33 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-5768 March 13, 2025 15:04 Abandoned
@joshblack joshblack added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 7b2eb4e Mar 13, 2025
44 checks passed
@joshblack joshblack deleted the joshblack-patch-4 branch March 13, 2025 18:20
@primer primer bot mentioned this pull request Mar 13, 2025
Merged
hectahertz pushed a commit that referenced this pull request Mar 20, 2025
@joshblack @hectahertz
Add -- prefix to CSS Custom Property for SkeletonBox (#5768)
1179a39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @francinelucca