-
Notifications
You must be signed in to change notification settings - Fork 609
Radio: Remove aria-required
and aria-invalid
#5760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…`Radio` component
🦋 Changeset detectedLatest commit: bc31fb5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
/** | ||
* Only used to inform ARIA attributes. Individual radio inputs do not have validation styles. | ||
*/ | ||
validationStatus?: FormValidationStatus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't advertise this prop in our docs, and it doesn't have any usage outside of the aria-*
props which are removed in this PR. The prop itself didn't add any functionality and I don't think this would need to be a major release. There's only one place (outside of Dotcom) that appears to utilize this prop.
Any thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TylerJDev if you feel like we can safely roll this out then I'm okay with that 👍 I think it would fall under a breaking change but I get if it doesn't feel worth it to migrate something we don't advertise and doesn't have usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely! I think this is one of those things that didn't really do anything, and was never adopted anywhere, so we can probably get away with just removing it 😄
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/366482 |
🟢 golden-jobs completed with status |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
Context https://github.com/github/primer/issues/3726
Removes
aria-required
andaria-invalid
from theRadio
component, as they are not required on the component. This change allows us to remove a lint disable fora11y-role-supports-aria-props
.Changelog
Removed
aria-invalid
andaria-required
fromRadio
Rollout strategy
Testing & Reviewing
Merge checklist