Skip to content

fix(SplitPageLayout): add className prop #5737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

hussam-i-am
Copy link
Contributor

Relates to https://github.com/github/primer/issues/4829

Changelog

New

Changed

Adds className prop to SplitPageLayout component

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@hussam-i-am hussam-i-am self-assigned this Mar 5, 2025
@hussam-i-am hussam-i-am requested a review from a team as a code owner March 5, 2025 19:03
@hussam-i-am hussam-i-am requested a review from joshblack March 5, 2025 19:03
Copy link

changeset-bot bot commented Mar 5, 2025

🦋 Changeset detected

Latest commit: fb3aca6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Mar 5, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.94 KB (0%)
packages/react/dist/browser.umd.js 106.3 KB (0%)

@hussam-i-am hussam-i-am added this pull request to the merge queue Mar 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2025
@hussam-i-am hussam-i-am added this pull request to the merge queue Mar 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2025
@hussam-i-am hussam-i-am added this pull request to the merge queue Mar 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2025
@hussam-i-am hussam-i-am added this pull request to the merge queue Mar 5, 2025
@hussam-i-am hussam-i-am removed this pull request from the merge queue due to a manual request Mar 5, 2025
@hussam-i-am hussam-i-am added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit 454ff20 Mar 5, 2025
49 checks passed
@hussam-i-am hussam-i-am deleted the hussam-i-am/splitpagelayout-classname branch March 5, 2025 23:09
@primer primer bot mentioned this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants